Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 )
Change subject: Fix ksck checksum_scan printing ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc@1338 PS4, Line 1338: FLAGS_ FLAGS_ksck_format is not visible here and I'm not sure why? http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc@1340 PS4, Line 1340: KsckResultsToJsonString I'm prob wrong. Isn't this function does what you mean by "test that slurps the stdout of ksck with compact json mode on into a stringstream and then parses it with a JsonReader"? -- To view, visit http://gerrit.cloudera.org:8080/10535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25fe6d0f14d1713b848d0a79f4d92b056924a5a5 Gerrit-Change-Number: 10535 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 30 May 2018 00:05:34 +0000 Gerrit-HasComments: Yes
