Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 )
Change subject: Fix ksck checksum_scan printing ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10535/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10535/5/src/kudu/tools/ksck.cc@592 PS5, Line 592: if (FLAGS_ksck_format == "plain_full" || FLAGS_ksck_format == "plain_concise") > Why is it machine-readable btw? My bad. By "this test" I meant the opposite of this test :). Machine-readable means JSON format. So the test should compare for equality against JSON_PRETTY and JSON_COMPACT. http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.cc@613 PS6, Line 613: I think you mean if it's not printing in a machine-readable format. http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.cc@1063 PS6, Line 1063: Also, these are the non-machine-readable format flags. -- To view, visit http://gerrit.cloudera.org:8080/10535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25fe6d0f14d1713b848d0a79f4d92b056924a5a5 Gerrit-Change-Number: 10535 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Jun 2018 22:27:48 +0000 Gerrit-HasComments: Yes
