Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 )
Change subject: Fix ksck checksum_scan printing ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/10535/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10535/6//COMMIT_MSG@15 PS6, Line 15: kudu cluster ksck --checksum_scan --checksum_snapshot=false : --ksck_format=json_compact localhost:7052,localhost:7051, : localhost:7053 > nit: Use \ to indicate the line breaks, so the command remains vaild and he Done http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck-test.cc@56 PS6, Line 56: DECLARE_uint32(truncate_serv > nit: Order alphabetically by flag name. Done http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck-test.cc@1503 PS6, Line 1503: ASSERT_OK(r.Init()); > Can you double-check this failed without this patch? I think JsonReader par Yes this failed w/o this patch. http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.h@568 PS6, Line 568: friend class KsckTest; > Can you make this a helper function in an anonymous namespace in ksck.cc ra Done http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10535/6/src/kudu/tools/ksck.cc@1063 PS6, Line 1063: summary.result = result; > We are usually case-insensitive about categorical flag values like this. Ca Done -- To view, visit http://gerrit.cloudera.org:8080/10535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25fe6d0f14d1713b848d0a79f4d92b056924a5a5 Gerrit-Change-Number: 10535 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Jun 2018 23:35:20 +0000 Gerrit-HasComments: Yes
