Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 )
Change subject: Fix ksck checksum_scan printing ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10535/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10535/5/src/kudu/tools/ksck.cc@592 PS5, Line 592: if (FLAGS_ksck_format == "plain_full" || FLAGS_ksck_format == "plain_concise") > nit: Can we do a tiny refactor and make a method like Ksck::IsMachineReadab Why is it machine-readable btw? -- To view, visit http://gerrit.cloudera.org:8080/10535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25fe6d0f14d1713b848d0a79f4d92b056924a5a5 Gerrit-Change-Number: 10535 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 06 Jun 2018 16:18:01 +0000 Gerrit-HasComments: Yes
