Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 )
Change subject: Fix ksck checksum_scan printing ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc@1338 PS4, Line 1338: FLAGS_ > FLAGS_ksck_format is not visible here and I'm not sure why? You need to DECLARE it when in a different compilation unit. See the declaration of --checksum_scan on L52. http://gerrit.cloudera.org:8080/#/c/10535/4/src/kudu/tools/ksck-test.cc@1340 PS4, Line 1340: KsckResultsToJsonString > I'm prob wrong. Not quite. If you look at KsckResultsToJsonString(), it prints the json output to an ostringstream, so the only output is the json output. We want *all* the output from ksck, to check that can be json-parsed. See Ksck::RunAndPrintResults e.g. on L364; calling that gathers all output into the err_stream_ member of the test class (since the Ksck instance is constructed to be outputting to err_stream_ (see L178). -- To view, visit http://gerrit.cloudera.org:8080/10535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25fe6d0f14d1713b848d0a79f4d92b056924a5a5 Gerrit-Change-Number: 10535 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 00:16:56 +0000 Gerrit-HasComments: Yes
