Hello Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11570
to review the following change.
Change subject: Extract connection retrying and HA support from HmsCatalog
......................................................................
Extract connection retrying and HA support from HmsCatalog
Introduces a new abstraction, thrift::HaClient, for providing HA and
retrying support on top of Thrift clients like HmsClient and
SentryClient. The implementation is extracted from HmsCatalog, and is
not changed in any significant ways.
The implementation is inlined into a header because the class requires a
template parameter (to choose between HmsClient or SentryClient), and
forward declaring these instantiations is not possible because the
thrift module does not link to the hms or sentry modules.
No new tests are provided, since the class is tested by the existing
master_hms-itest test, and providing tests in the thrift module is not
possible because there are no concrete instantiations which can be done
without HmsClient or SentryClient.
This patch should have little or no functional changes.
Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296
---
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/sentry/sentry_client.cc
M src/kudu/sentry/sentry_client.h
M src/kudu/thrift/client.cc
M src/kudu/thrift/client.h
8 files changed, 309 insertions(+), 230 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11570/1
--
To view, visit http://gerrit.cloudera.org:8080/11570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296
Gerrit-Change-Number: 11570
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
