Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11570 )
Change subject: Extract connection retrying and HA support from HmsCatalog ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/hms/hms_catalog.h File src/kudu/hms/hms_catalog.h: http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/hms/hms_catalog.h@37 PS2, Line 37: class HostPort; nit: alphabetical order http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/thrift/client.h@119 PS2, Line 119: // Client options nit: Move to L121. http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/thrift/client.h@137 PS2, Line 137: which live in modules which are not : // linked to be the thrift module. Not quite follow this. Do you mean 'which live in modules to which the thrift module are not linked'? -- To view, visit http://gerrit.cloudera.org:8080/11570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Gerrit-Change-Number: 11570 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 03 Oct 2018 00:14:01 +0000 Gerrit-HasComments: Yes
