Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11570 )
Change subject: Extract connection retrying and HA support from HmsCatalog ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11570/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/11570/1/src/kudu/hms/hms_catalog.cc@152 PS1, Line 152: optional<const string&> owner, > warning: the parameter 'owner' is copied for each invocation but only used This wasn't changed, and it's a bad suggestion so I'm going to ignore. http://gerrit.cloudera.org:8080/#/c/11570/1/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/11570/1/src/kudu/thrift/client.h@85 PS1, Line 85: bool IsFatalError(const Status& error); > warning: function 'kudu::thrift::IsFatalError' has a definition with differ Done -- To view, visit http://gerrit.cloudera.org:8080/11570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Gerrit-Change-Number: 11570 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 02 Oct 2018 23:17:09 +0000 Gerrit-HasComments: Yes
