Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 )
Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG@10 PS3, Line 10: show > nit: shown Done http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG@28 PS3, Line 28: see what was going in once there were a lot of rowsets. > I wonder if we could color-code the rectangles somehow to indicate this? I worry that either the colors would be too similar, like shades of blue, so that it would be hard to get a lot of information out of the diagram; or, they would be so different, it might be a splatter painting, and likewise be hard to read. Maybe something to play with for a different patch? There's a lot of ways to tweak coloring to show size. http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG@37 PS3, Line 37: https://github.com/wdberkeley/kudu/blob/svg_screenshots/layout.png : : And here's how it looks without them: : : https://github.com/wdberkeley/kudu/blob/svg_screenshots/layout_no_text.png > Maybe it's there and just not pictured, but is there also a count of the ro No, that's a good thing to add. http://gerrit.cloudera.org:8080/#/c/11613/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11613/3/src/kudu/tablet/tablet.cc@2316 PS3, Line 2316: <div><p>In addition to the rowsets pictured and listed, " : "there are $0 rowset(s) currently undergoing compactions." : "</p></div> > Should this be `num_rowsets_unavailable_for_compaction - 1` for the MRS? Hrm, yeah, it looks like it should, but that's wrong when I test it (gives -1). I'm actually not sure why that is, but I added an extra condition (that's used elsewhere) to filter out the MRS. -- To view, visit http://gerrit.cloudera.org:8080/11613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7475f14093a187fde1329546b10c314da49fe08a Gerrit-Change-Number: 11613 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 05:42:47 +0000 Gerrit-HasComments: Yes
