Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 )
Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc@2315 PS4, Line 2315: return rowset->metadata() && !rowset->IsAvailableForCompaction(); > Ah I should have dug around a bit, MemRowSet::IsAvailableForCompaction() al Sorry I didn't conclude this thought. The first condition isn't needed because the the second condition also excludes the memrowset. -- To view, visit http://gerrit.cloudera.org:8080/11613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7475f14093a187fde1329546b10c314da49fe08a Gerrit-Change-Number: 11613 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 17:30:06 +0000 Gerrit-HasComments: Yes
