Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 )
Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG@28 PS3, Line 28: see what was going in once there were a lot of rowsets. > I worry that either the colors would be too similar, like shades of blue, s FWIW I've seen gray-scale (or blue-scale) boxes be pretty effective in illustrating size/capacity, though what I've seen I've only seen for around a dozen "boxes" or so. It might not be effective when there are a significantly larger number of rowsets. +1 on a separate patch for it. http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc@2315 PS4, Line 2315: return rowset->metadata() && !rowset->IsAvailableForCompaction(); Ah I should have dug around a bit, MemRowSet::IsAvailableForCompaction() always returns false. http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc@2355 PS4, Line 2355: rowset_sizes.size() nit: use `num_rowsets`? -- To view, visit http://gerrit.cloudera.org:8080/11613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7475f14093a187fde1329546b10c314da49fe08a Gerrit-Change-Number: 11613 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 05:56:01 +0000 Gerrit-HasComments: Yes
