Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd
Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11613
to look at the new patch set (#5).
Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements
......................................................................
[webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements
This patch addresses KUDU-844, an issue where rowsets unavailable for
compaction weren't shown in the rowset SVG layout. These rowsets aren't
displayed because the rowset SVG is built from compaction policy output,
and the compaction policy obviously does not consider rowsets that
aren't available for compaction. There are two kinds of rowsets that
will be excluded: the memrowset, which doesn't belong in the SVG output,
and rowsets currently being compacted. The latter are tricky to
integrate into the SVG because there is a race with the compaction
finishing, and after a compaction the rowset may no longer be
relevant (merge compaction), or its bounds may have changed (major delta
compaction). Working around this problem would be a lot of effort, just
to add dubiously useful information to the layout diagram. Instead, I
opted just to disclose the issue: there's a note saying how many rowsets
are currently being compacted included under the layout diagram.
I also made a couple of quality of life improvements to the rowset
layout page.
1. I removed the size label from the rowsets rectangles in the SVG. They
didn't add so much individually, but they did make it really hard to
see what was going in once there were a lot of rowsets.
2. I added a table with the 5-number summary of rowset sizes, to make up
for taking away the individual sizes in the diagram. I chose the
summary because in my experience it's the best way to get a quick
idea what a distribution looks like (better than, e.g., the mean and
standard deviation.)
Here's the original way a busy layout diagram looks with the sizes:
https://github.com/wdberkeley/kudu/blob/svg_screenshots/layout.png
And here's how it looks without them:
https://github.com/wdberkeley/kudu/blob/svg_screenshots/layout_no_text.png
Here's an example summary table:
https://github.com/wdberkeley/kudu/blob/svg_screenshots/new_layout_page.png
Finally, I added some <tr> pairs that were missing from the /tablets
template.
Change-Id: I7475f14093a187fde1329546b10c314da49fe08a
---
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet.cc
M www/tablets.mustache
3 files changed, 69 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/11613/5
--
To view, visit http://gerrit.cloudera.org:8080/11613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7475f14093a187fde1329546b10c314da49fe08a
Gerrit-Change-Number: 11613
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
