Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 )
Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11613/3//COMMIT_MSG@28 PS3, Line 28: see what was going in once there were a lot of rowsets. > FWIW I've seen gray-scale (or blue-scale) boxes be pretty effective in illu Aye, I'm worried the "hue space" won't be big enough when rowsets might differ in size by an order of magnitude and there's like 1000 and they are all 15 pixels wide and smooshed together. There's ways to adjust but it would take some experimentation to find what works well. http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11613/4/src/kudu/tablet/tablet.cc@2355 PS4, Line 2355: HumanReadableNumByt > nit: use `num_rowsets`? Oops. -- To view, visit http://gerrit.cloudera.org:8080/11613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7475f14093a187fde1329546b10c314da49fe08a Gerrit-Change-Number: 11613 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 09 Oct 2018 17:05:49 +0000 Gerrit-HasComments: Yes
