Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: Add ts location to both client and internal client ...................................................................... Patch Set 1: (1 comment) Overall looks good. Does it make sense to add some simple test to verify the location is propagated from the master TS registry down to the objects where it has been added? http://gerrit.cloudera.org:8080/#/c/11679/1/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/11679/1/src/kudu/client/meta_cache.h@122 PS1, Line 122: std::string location_ nit: add 'const' since it doesn't change during the lifecycle of the object. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sun, 14 Oct 2018 23:50:14 +0000 Gerrit-HasComments: Yes
