Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: [location_awareness] Add ts location to both client and internal client ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: Add ts location to both client and internal client > This isn't quite correct though because you've annotated location() in clie I'm not sure if I understand. We make it a private API so that the client can be location-aware and this API is not necessarily public? http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@11 PS2, Line 11: RemoteTabletServer > This itself is a client-side class that gets its info from TSInfoPB so I th Done http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@14 PS2, Line 14: So I added the location into them in order to ensure the consistency > nit: Unnecessary line break. Done http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/client/client.h@631 PS2, Line 631: const KUDU_NO_EXPORT std::string& location() const; > For functions, KUDU_NO_EXPORT has to come at the end. See commit ed60c11a3 I see. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 18 Oct 2018 21:15:55 +0000 Gerrit-HasComments: Yes
