Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: Add ts location to both client and internal client ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@11 PS2, Line 11: RemoteTabletServer This itself is a client-side class that gets its info from TSInfoPB so I think it's more appropriate to say you are adding location info to client::KuduTabletServer and client::internal::RemoteTabletServer. http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@14 PS2, Line 14: So I added the location into them in order to ensure the consistency nit: Unnecessary line break. http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/master/master.proto@381 PS2, Line 381: optional string location = 3; > Wasn't expecting to see this change as part of this patch; the entirety of Also this patch doesn't really accomplish anything without the server-side change to populate the field. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 20:00:20 +0000 Gerrit-HasComments: Yes
