Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: Add ts location to both client and internal client ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: Add ts location to both client and internal client This isn't quite correct though because you've annotated location() in client.h with KUDU_NO_EXPORT. What's the motivation for exposing it as a private API? http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/client/client.h@631 PS2, Line 631: const KUDU_NO_EXPORT std::string& location() const; For functions, KUDU_NO_EXPORT has to come at the end. See commit ed60c11a3 for more details. http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/11679/2/src/kudu/master/master.proto@381 PS2, Line 381: optional string location = 3; Wasn't expecting to see this change as part of this patch; the entirety of the patch is client-side, except for this bit. Normally when we plumb something through to the clients, we structure it as three separate patches: 1. Server-side patch. 2. C++ client-side patch. 3. Java client-side patch. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 03:14:29 +0000 Gerrit-HasComments: Yes
