Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@12 PS2, Line 12: test Nit: tests http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@16 PS2, Line 16: We currently inject errors into JUnit XML report if any leaks are found. : This patch updates this to only inject these errors if the test also : failed. Hmm, I don't really understand why this is safe. Are you 100% sure that a leak without a corresponding test failure constitutes a false positive? What evidence supports this? Have you tried something different, such as adding a ScopedLeakCheckDisabler to the string allocation within Thread::SuperviseThread? Or, in GenericServiceImpl::CheckLeaks, either looping further or sleeping for longer in between loop cycles? -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Nov 2018 00:23:49 +0000 Gerrit-HasComments: Yes
