Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@16 PS2, Line 16: Direct leak of 58 byte(s) in 1 object(s) allocated from: : #0 0x5318c8 in operator new(unsigned long) /data/8/awong/kudu/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/asan/asan_new_delete.cc:92 : #1 > Oh, so this is squarely the "false positive leak that goes away if __lsan_d Right. Todd suggested maybe patching LSAN so that it logs into a buffer instead of stdout/stderr during __lsan_do_recoverable_leak_check(), but looking into that, it seems there'd be a decent amount of plumbing to get that. I'm somewhat conflicted because it's still uncertain whether this is the only class of leak that will not fail a test. That said, I don't think the injected JUnit errors are particularly helpful; presumably if the leak were real and worth developer attention, it would be surfaced as a test failure anyway. -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Nov 2018 22:23:01 +0000 Gerrit-HasComments: Yes
