Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@12 PS2, Line 12: test > Nit: tests Ack http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@16 PS2, Line 16: We currently inject errors into JUnit XML report if any leaks are found. : This patch updates this to only inject these errors if the test also : failed. > Hmm, I don't really understand why this is safe. Are you 100% sure that a l Ah, I like that approach much better. You're right that it isn't clear why this would be 100% safe. The paranoid part of me isn't thrilled with this either; I'll test out your suggestion to disable the checker in SuperviseThread. Not sure about the CheckLeaks suggestion though; the issue is that the leak _is_ transient, and thus already doesn't show up after multiple loops in the CheckLeaks() call, hence the tests do _not_ fail. -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 17:19:57 +0000 Gerrit-HasComments: Yes
