Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11886/2//COMMIT_MSG@16 PS2, Line 16: We currently inject errors into JUnit XML report if any leaks are found. : This patch updates this to only inject these errors if the test also : failed. > Ah, I like that approach much better. You're right that it isn't clear why Oh, so this is squarely the "false positive leak that goes away if __lsan_do_recoverable_leak_check() is called again" issue? I didn't realize LSAN still prints a leak report in that case, but I guess that's to be expected. Unfortunately I don't see a way to control the printing of the report at runtime within LSAN. In that case, maybe your original solution is the correct one. Maybe we should also print something in GenericServiceImpl::CheckLeaks to the effect of "LSAN found false positives, ignore them". -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 17:29:41 +0000 Gerrit-HasComments: Yes
