Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@167 PS1, Line 167: Return an array of TestExecution objects. Please doc tests_regex and extra_args. http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@170 PS1, Line 170: ctest_argv = [ctest_bin, "-V", "-N", "-LE", "no_dist_test"] I ran this command and was surprised to see that we emit KUDU_DATA_FILES into the test environment even when there's no DATA_FILES entries. That appears to be due to the unconditional use of DATA_FILES_LIST in the top-level CMakeLists.txt. Could you fix that? http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@517 PS1, Line 517: # Build the list of executions corresponding to the test. It's better to do Won't this also shard the test? Seems like the epilog for 'loop' would need to be updated, at a minimum. You should read https://gerrit.cloudera.org/c/9470/2/build-support/dist_test.py#442 before proceeding. I'm worried this change might break the "loop build/latest/bin/foo-test" workflow; does it? -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Nov 2018 22:50:22 +0000 Gerrit-HasComments: Yes
