Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@167 PS1, Line 167: Return an array of TestExecution objects. > Please doc tests_regex and extra_args. Done http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@170 PS1, Line 170: ctest_argv = [ctest_bin, "-V", "-N", "-LE", "no_dist_test"] > Yep, I'll take a look. http://gerrit.cloudera.org:8080/11907 http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@517 PS1, Line 517: # Build the list of executions corresponding to the test. It's better to do > Yes, this will automatically shard the test. Isn't it good? In offline discussion Todd suggested to use the presence of the --gtest_filter option to decide whether to shard or not. -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Nov 2018 02:15:56 +0000 Gerrit-HasComments: Yes
