Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@170 PS1, Line 170: ctest_argv = [ctest_bin, "-V", "-N", "-LE", "no_dist_test"] > I ran this command and was surprised to see that we emit KUDU_DATA_FILES in Yep, I'll take a look. http://gerrit.cloudera.org:8080/#/c/11905/1/build-support/dist_test.py@517 PS1, Line 517: # Build the list of executions corresponding to the test. It's better to do > Won't this also shard the test? Seems like the epilog for 'loop' would need Yes, this will automatically shard the test. Isn't it good? I'll take a look at the review item, sure. However, I can report that the 'loop build/latest/bin/foo-test' isn't broken (you can check the commit message for some evidence). Instead, it runs much faster now if the test has shards defined. -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Nov 2018 23:17:09 +0000 Gerrit-HasComments: Yes
