Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.h@51 PS1, Line 51: // BindMode lets you specify the socket binding mode for RPC and/or HTTP server. Nit: reformat to bring this stuff closer to GetBindIpForDaemon, which is where it is principally used. http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc@495 PS1, Line 495: case BindMode::UNIQUE_LOOPBACK: { Now that this method is free of the mini cluster framework, we should reassess whether it makes sense to keep this complicated DaemonType/index logic. As I see it, in a standalone test where we want to start one external server (such as Sentry), there are a few simpler options: 1. Don't use an index at all, since we're only starting one server. 2. Let the test maintain the index to daemon mapping and simplify this to take just a single index argument. 3. Let GetBindIpForDaemon maintain the index as a static counter. Options 2 and 3 may also be usable by the mini cluster. So, what do you think makes the most sense? -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 19:52:42 +0000 Gerrit-HasComments: Yes
