Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/mini-cluster/external_mini_cluster.cc@525 PS3, Line 525: index, opts_.bind_mode); Nit: indentation. http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/sentry/sentry-test-base.h File src/kudu/sentry/sentry-test-base.h: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/sentry/sentry-test-base.h@44 PS3, Line 44: #if defined(__linux__) : host = GetBindIpForDaemon(1, BindMode::UNIQUE_LOOPBACK); : #elif defined(__APPLE__) : host = GetBindIpForDaemon(1, BindMode::LOOPBACK); : #endif Shouldn't this use kDefaultBindMode? http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h@165 PS3, Line 165: // BindMode lets you specify the socket binding mode for RPC and/or HTTP server. Given that ExternalMiniCluster isn't test code anymore, I don't think this stuff belongs in test_util (since EMC depends on it). Maybe util/net/net_util.h? -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 05:47:58 +0000 Gerrit-HasComments: Yes
