Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/mini-cluster/external_mini_cluster.cc@525 PS3, Line 525: string ExternalMiniCluster::GetBindIpForExternalServer(int index) const { > Nit: indentation. Done http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/sentry/sentry-test-base.h File src/kudu/sentry/sentry-test-base.h: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/sentry/sentry-test-base.h@44 PS3, Line 44: std::string host = GetBindIpForDaemon(1, kDefaultBindMode); : HostPort address(host, 0); : sentry_->SetAddress(address); : if (kerberos_enabled_) { : > Shouldn't this use kDefaultBindMode? Done http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h@165 PS3, Line 165: > Given that ExternalMiniCluster isn't test code anymore, I don't think this Done http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h@206 PS3, Line 206: > We're kind of far away from daemons at this point. Maybe discuss what guara Done http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.cc@514 PS3, Line 514: > nit: spacing Discussed with Andrew offline. I think this is a false alarm. -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 Dec 2018 02:49:10 +0000 Gerrit-HasComments: Yes
