Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.h@206 PS3, Line 206: // Return the IP address that the daemon with the given index will bind to. We're kind of far away from daemons at this point. Maybe discuss what guarantees we can expect based on the index? E.g. what happens when you call this twice with the same index vs with different indexes? http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.cc@514 PS3, Line 514: "last I nit: spacing -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Dec 2018 21:06:02 +0000 Gerrit-HasComments: Yes
