Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc@495 PS1, Line 495: case BindMode::UNIQUE_LOOPBACK: { > Now that this method is free of the mini cluster framework, we should reass This function should be usable by the mini cluster as well. And it is more nature and easier for the caller to maintain the index. Thus, I think option 2 makes most sense. I will update the patch to reflect it. -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 21:41:45 +0000 Gerrit-HasComments: Yes
