Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc@451 PS4, Line 451: string GetBindIpForDaemon(int index, BindMode bind_mode) { > You can reuse this constant in kServersMaxNum too. Done http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_util.cc@452 PS4, Line 452: // The server index should range from (0, max_servers] since > I think I missed something: why did the requirements of 'index' change such I changed it as I removed the logic of assign index based on the type to GetBindIpForDaemonWithType(). My understanding of the reason why we were doing this, is 'the last octet of a valid unicast IP address is (0, 255)'. Therefore the index should start from 1 and <= max_servers. I will add a comment here. -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 22 Jan 2019 22:00:37 +0000 Gerrit-HasComments: Yes
