Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG@19 PS4, Line 19: so I set the timeout to 10000ms, which is much larger than the default : for the C++ client > Sure, the C++ client should have it too. You want me to add that to this pa Doesn't have to be this patch specifically (could be a follow-up), but yeah, I'd like the clients to remain consistent unless there's good reason not to. http://gerrit.cloudera.org:8080/#/c/12363/7/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: http://gerrit.cloudera.org:8080/#/c/12363/7/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java@135 PS7, Line 135: private static final long NEGOTIATION_TIMEOUT_MS = 500; I think you want to revert this, right? -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 7 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 23:24:35 +0000 Gerrit-HasComments: Yes
