Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG@19 PS4, Line 19: so I set the timeout to 10000ms, which is much larger than the default : for the C++ client > Not clear why you used 10s and not 3s if that's what the C++ client uses; w It's possible to raise the server-side timeout. So, without adding plumbing to allow people to raise the client-side timeout, leaving some breathing room for the timeout to be raised seemed reasonable. http://gerrit.cloudera.org:8080/#/c/12363/4/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/12363/4/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@90 PS4, Line 90: table = harness.getClient().createTable(TABLE_NAME, getBasicSchema(), builder); : } : > Don't need this anymore; just use the client that's provided by the harness Done -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 19:14:51 +0000 Gerrit-HasComments: Yes
