Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG@19 PS4, Line 19: so I set the timeout to 10000ms, which is much larger than the default : for the C++ client > It's possible to raise the server-side timeout. So, without adding plumbing That doesn't answer my question though. Let me make sure I understood what you're saying: 1. The server negotiation timeout defaults to 3s, and is configurable. 2. The C++ client negotiation timeout is 3s, and is static. 3. In this patch, the Java client negotiation timeout is set to 10s, and is also static. I'm wondering what makes the Java client special that it shouldn't be exactly the same as the C++ client. If you want to allow for breathing room that's fine, but shouldn't the C++ client also get the same breathing room? -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 22:10:14 +0000 Gerrit-HasComments: Yes
