Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/12363/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12363/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2519 PS6, Line 2519: info nit: should it be a warning instead? It seems the behavior of this method has changed in addition to the fact of the deprecation. http://gerrit.cloudera.org:8080/#/c/12363/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java: PS6: Is there a test to verify that the negotiation timeout works? http://gerrit.cloudera.org:8080/#/c/12363/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@69 PS6, Line 69: nit: is this just an extra line with spaces? -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 01:02:23 +0000 Gerrit-HasComments: Yes
