Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: WIP: Expose RPC interface for diff scan ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12592/1/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/12592/1/src/kudu/tserver/tserver.proto@256 PS1, Line 256: // The start timestamp of a diff scan. If set, 'snap_timestamp' must also be Would it make sense to make this more explicit and add to the ReadMode enum in common.proto? Today READ_AT_SNAPSHOT requires a snap_timestamp, we could at a READ_DIFF that requires both snap_start_timestamp and snap_timestamp. -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Feb 2019 22:57:13 +0000 Gerrit-HasComments: Yes
