Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: KUDU-2744: Expose RPC interface for diff scan ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@212 PS4, Line 212: #define RETURN_NOT_OK_WITH_ERROR_CODE(expr, error_code_ret, error_code) \ This macro does not seem to have anything specific to this module. Why would we want to keep it here and not in util/status.h ? -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2019 00:47:40 +0000 Gerrit-HasComments: Yes
