Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: WIP: Expose RPC interface for diff scan ...................................................................... Patch Set 1: (1 comment) Sorry for the piecewise comments, just adding them as I explore the Java implementation. http://gerrit.cloudera.org:8080/#/c/12592/1/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/12592/1/src/kudu/tserver/tserver.proto@258 PS1, Line 258: optional fixed64 snap_start_timestamp = 15; I think we many need this field on ScanTokenPB in client.proto based on early java implementation exploration. -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Feb 2019 23:26:48 +0000 Gerrit-HasComments: Yes
