Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: WIP: Expose RPC interface for diff scan ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12592/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12592/3/src/kudu/tserver/tablet_service.cc@2451 PS3, Line 2451: opts.snap_to_exclude = MvccSnapshot(Timestamp(scan_pb.snap_start_timestamp())); Should we validate this isn't older than the AHM here? http://gerrit.cloudera.org:8080/#/c/12592/3/src/kudu/tserver/tablet_service.cc@2452 PS3, Line 2452: opts.include_deleted_rows = true; Should this only be set if an is_deleted column is in the projection? -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Mar 2019 21:04:44 +0000 Gerrit-HasComments: Yes
