Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: KUDU-2744: Expose RPC interface for diff scan ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.h@160 PS4, Line 160: a the Nit: either a or the but not both. http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@2171 PS4, Line 2171: // We have to check after we open the iterator in order to avoid a TOCTOU : // error. I found it confusing that the AHM verification happens after the iterator is created; can you elaborate on the nature of the TOCTOU here? Would it at least be possible to do the verification before Init(), since that can be an expensive step? http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@2477 PS4, Line 2477: if (scan_pb.read_mode() != READ_AT_SNAPSHOT) { Should we also enforce that opts.order is ORDERED? http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@271 PS4, Line 271: // the IS_DELETED column set to true were deleted in between the start and was But I think the sentence might read better if flipped (i.e. "Any row deleted between the start and end timestamps will have its IS_DELETED column set to true"). http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@272 PS4, Line 272: , and Nit: previous sentence is already long; terminate with a period here and say something like "In this case, any non-primary key..." http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@277 PS4, Line 277: was inserted or whether it was updated. Nit: "was included in the results because it was inserted or because it was updated". -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 22:35:04 +0000 Gerrit-HasComments: Yes
