Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 )
Change subject: [master] introduce TTL-based cache ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12652/1/src/kudu/master/ttl_cache-test.cc File src/kudu/master/ttl_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/12652/1/src/kudu/master/ttl_cache-test.cc@79 PS1, Line 79: ASSERT_EQ(5, cache.size()); Could you add a comment explaining why you expect cache size to be 5 here? http://gerrit.cloudera.org:8080/#/c/12652/1/src/kudu/master/ttl_cache-test.cc@85 PS1, Line 85: shoule nit, typo: "should"? -- To view, visit http://gerrit.cloudera.org:8080/12652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If214fe19810728fa590d1e0a3e5b2da86b020ac2 Gerrit-Change-Number: 12652 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Mar 2019 19:46:45 +0000 Gerrit-HasComments: Yes
