Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 )
Change subject: [master] introduce TTL-based cache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12652/1/src/kudu/master/ttl_cache.h File src/kudu/master/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/12652/1/src/kudu/master/ttl_cache.h@45 PS1, Line 45: CHECK(capacity_ > 0) << "cache capacity should be greater than 0"; I wonder if there is a legitimate case for 0-capacity cache, such as disabling the cache altogether. Will there be another way to disable the cache? -- To view, visit http://gerrit.cloudera.org:8080/12652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If214fe19810728fa590d1e0a3e5b2da86b020ac2 Gerrit-Change-Number: 12652 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Mar 2019 19:48:33 +0000 Gerrit-HasComments: Yes
