Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 )
Change subject: [util] introduce TTL-based cache ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12652/2//COMMIT_MSG Commit Message: PS2: I think I'll try an alternative approach: adapting already existing LRU cache in util/cache.{h,cc} to be used for the TTL cache. One of the anticipated benefits of the alternative approach is to make sure the cache eviction policy depends not only on the capacity of the cache expressed in number of items, but also a limit expressed in amount of maximum memory used for the cache. If I found it's easy to add the memory tracking into this implementation, I'll get back to this separate (simple and small) implementation. -- To view, visit http://gerrit.cloudera.org:8080/12652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If214fe19810728fa590d1e0a3e5b2da86b020ac2 Gerrit-Change-Number: 12652 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Mar 2019 17:02:16 +0000 Gerrit-HasComments: Yes
