Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/12652 )
Change subject: [master] introduce TTL-based cache
......................................................................
Patch Set 1:
> Did you look into augmenting the existing generic cache code in
> util/cache.{cc,h}? It's got rougher edges (e.g. you have to
> serialize/copy keys and values rather than using C++ objects), but
> it's also received a fair amount of performance tuning already, and
> supports some neat features like metrics and memtracker
> integration.
Thank you for the comment.
Yep, I took a look at that cache prior starting working on this one. I think
the cache in util/cache.{cc,h} looks very solid but a bit complicated for this
simple case. Ideally I'd like to have the simple TTL-based cache with all the
nice metrics and memtracker integration. Probably, I'll need to think about
some common base to use some common code there and here.
--
To view, visit http://gerrit.cloudera.org:8080/12652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If214fe19810728fa590d1e0a3e5b2da86b020ac2
Gerrit-Change-Number: 12652
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Mar 2019 19:43:10 +0000
Gerrit-HasComments: No
