Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/12652 )
Change subject: [master] introduce TTL-based cache
......................................................................
Patch Set 1:
> Yep, I took a look at that cache prior starting working on this one. I think
> the cache in util/cache.{cc,h} looks very solid but a bit complicated for
> this simple case. Ideally I'd like to have the simple TTL-based cache with
> all the nice metrics and memtracker integration. Probably, I'll need to
> think about some common base to use some common code there and here.
Yeah I think both of those features are table stakes for the Sentry privilege
cache. Metrics especially; you could make the argument that memtracker
integration isn't as important if the footprint of the cache is low.
You can also look at util/file_cache.{cc,h}. The overall model doesn't make
sense for this use case, but it's an example of having a different interface on
top of the more generic util/cache.{cc,h}. The same is true for
cfile/block_cache.{cc.h}, though to a lesser extent.
--
To view, visit http://gerrit.cloudera.org:8080/12652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If214fe19810728fa590d1e0a3e5b2da86b020ac2
Gerrit-Change-Number: 12652
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Mar 2019 20:06:29 +0000
Gerrit-HasComments: No
