Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 )
Change subject: KUDU-2744: Expose RPC interface for diff scan ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.h@160 PS4, Line 160: a the > Nit: either a or the but not both. Done http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@212 PS4, Line 212: #define RETURN_NOT_OK_WITH_ERROR_CODE(expr, error_code_ret, error_code) \ > This macro does not seem to have anything specific to this module. Why woul I'm not sure it has enough use to warrant moving into a permanent library home, but now a moot point since I did a little refactoring after Adar's suggestions and didn't need it anymore. http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@2171 PS4, Line 2171: // We have to check after we open the iterator in order to avoid a TOCTOU : // error. > I found it confusing that the AHM verification happens after the iterator i Updated the comment and added support for validating the start timestamp against the AHM before Init() http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tablet_service.cc@2477 PS4, Line 2477: if (scan_pb.read_mode() != READ_AT_SNAPSHOT) { > Should we also enforce that opts.order is ORDERED? Done http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@271 PS4, Line 271: // the IS_DELETED column set to true were deleted in between the start and > was Done http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@272 PS4, Line 272: , and > Nit: previous sentence is already long; terminate with a period here and sa Done http://gerrit.cloudera.org:8080/#/c/12592/4/src/kudu/tserver/tserver.proto@277 PS4, Line 277: was inserted or whether it was updated. > Nit: "was included in the results because it was inserted or because it was Done -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9602b549dc499f92b2069b297e66f366e51fb312 Gerrit-Change-Number: 12592 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2019 01:10:16 +0000 Gerrit-HasComments: Yes
