Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 )
Change subject: sentry: generate TablePrivilegePBs ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12941/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12941/3//COMMIT_MSG@9 PS3, Line 9: This patch allos the authz provider to generate TablePrivilegePBs, which allows http://gerrit.cloudera.org:8080/#/c/12941/3/src/kudu/master/authz_provider.h File src/kudu/master/authz_provider.h: http://gerrit.cloudera.org:8080/#/c/12941/3/src/kudu/master/authz_provider.h@87 PS3, Line 87: const SchemaPB& schema_pb, Not immediately clear why the input is a SchemaPB and not a Schema. http://gerrit.cloudera.org:8080/#/c/12941/2/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/12941/2/src/kudu/master/sentry_authz_provider.cc@555 PS2, Line 555: user, &privileges)); > I'm not sure that's exactly the case, given we're using a SchemaPB to map c Fair enough. Maybe add a comment about that "uncacheability" here? -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 08 Apr 2019 23:41:05 +0000 Gerrit-HasComments: Yes
