Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 )
Change subject: sentry: populate TablePrivilegePBs ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/authz_provider.h File src/kudu/master/authz_provider.h: http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/authz_provider.h@88 PS4, Line 88: security::TablePrivilegePB > Did you consider other ways of passing information about table privileges t I didn't. I guess it's not a bad idea, but I'm kind of against introducing yet another "privilege" object (eg we already have AuthorizablePrivilege, SentryPrivilegeBranch, TablePrivilegePB), especially when this one fits the bill well enough. http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@340 PS4, Line 340: SentryAuthzProviderFilterPrivilegesTest > I start to seeing timeout for /sentry_authz_provider-test.cc, maybe conside https://gerrit.cloudera.org/c/12966/1 http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@341 PS4, Line 341: const > nit: maybe add constexpr for extra sugar? Done http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@386 PS4, Line 386: the column sco > 'the column scope' ? Done http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@439 PS4, Line 439: te("$0 > If not excluding some fields from comparison, why not to use Equals()/Equiv Done http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@440 PS4, Line 440: } > nit: should the indent be 4 here? Done -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2019 07:45:04 +0000 Gerrit-HasComments: Yes
