Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 )
Change subject: sentry: populate TablePrivilegePBs ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@340 PS4, Line 340: SentryAuthzProviderFilterPrivilegesTest I start to seeing timeout for /sentry_authz_provider-test.cc, maybe consider to shard the tests? http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@440 PS4, Line 440: << Substitute("$0 vs $1", SecureDebugString(expected_pb), SecureDebugString(privilege_pb)); nit: should the indent be 4 here? -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2019 05:27:28 +0000 Gerrit-HasComments: Yes
