Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 )
Change subject: sentry: populate TablePrivilegePBs ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/authz_provider.h File src/kudu/master/authz_provider.h: http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/authz_provider.h@88 PS4, Line 88: security::TablePrivilegePB Did you consider other ways of passing information about table privileges that would not include table_id and other irrelevant to this interface field? I.e., the idea is to use some other structure to pass that information around in this API. http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@341 PS4, Line 341: const nit: maybe add constexpr for extra sugar? http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@386 PS4, Line 386: a scope column 'the column scope' ? http://gerrit.cloudera.org:8080/#/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc@439 PS4, Line 439: Compare If not excluding some fields from comparison, why not to use Equals()/Equivalent() ? -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2019 00:45:14 +0000 Gerrit-HasComments: Yes
