Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 )
Change subject: sentry: populate TablePrivilegePBs ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/12941/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12941/3//COMMIT_MSG@9 PS3, Line 9: This patch allows the authz provider to populate TablePrivilegePBs, > allows Done http://gerrit.cloudera.org:8080/#/c/12941/3/src/kudu/master/authz_provider.h File src/kudu/master/authz_provider.h: http://gerrit.cloudera.org:8080/#/c/12941/3/src/kudu/master/authz_provider.h@87 PS3, Line 87: const SchemaPB& schema_pb, > Not immediately clear why the input is a SchemaPB and not a Schema. It's a limitation of what's available in the catalog manager. A SchemaPB is available from the TableInfo, not a Schema. We could do some translation, but I don't think it'd be worth it. I'm hesitant to document this, since it doesn't seem particularly important. http://gerrit.cloudera.org:8080/#/c/12941/2/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/12941/2/src/kudu/master/sentry_authz_provider.cc@555 PS2, Line 555: // because the column-level privileges depend on the input schema, which may > Fair enough. Maybe add a comment about that "uncacheability" here? Done -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2019 00:16:33 +0000 Gerrit-HasComments: Yes
